search

vermiculus / sx.el

Stack Exchange for Emacs
http://stackapps.com/q/3950
709 stars 40 forks source link

Fixes for byte compiler & update travis #338

Open jabranham opened 6 years ago

jabranham commented 6 years ago

Various fixes so the byte compiler is satisfied, a few checkdoc fixes.

string-as-unibyte is obsolete in upcoming Emacs 26, Can you double-check that (encode-coding-string data 'no-conversion) is right?

jabranham commented 6 years ago

Rebased onto master @vermiculus

vermiculus commented 6 years ago

Sorry I've been absent; I'll take a look at this by tomorrow night.

jabranham commented 6 years ago

No problem, and no rush!

jabranham commented 6 years ago

Rebased, and fixed a few more things the byte compiler was complaining about

jabranham commented 6 years ago

Pushed a commit to make travis error on compiler warnings

vermiculus commented 6 years ago

Turns out I lied ☹️

Do you mind if I keep this open anyway?

jabranham commented 6 years ago

Yes, sorry I didn't mean to close. Was looking at old lingering PRs and must've hit the wrong button.

vermiculus commented 7 months ago

Is this something that's still valuable to merge after all this time? Happy to do so if so.