search

vermiculus / sx.el

Stack Exchange for Emacs
http://stackapps.com/q/3950
709 stars 40 forks source link

Fix sx-inbox--print-info to handle all forms of notification #343

Closed Boruch-Baum closed 6 years ago

Boruch-Baum commented 6 years ago

The code had not been handling all notification types, nor the conditions of a notification lacking a title or body, which surprisingly is sometimes the case.

Boruch-Baum commented 6 years ago

This fixes my bug report of issue #339.

Boruch-Baum commented 6 years ago

I don't get this "travis CI" stuff. Look at the trivial code changes in this pull request. There's nothing that should fail an integration - it's just a when, an or, and a default for a cond.

vermiculus commented 6 years ago

The Travis builds are failing for separate reasons; don't worry about them 😄

vermiculus commented 6 years ago

Changes look fine; thanks!!

Boruch-Baum commented 6 years ago

Problem. This is no longer working for me. How is it on your end? I'm now getting an error, "propertize: Wrong type argument: sequencep, face".

Boruch-Baum commented 6 years ago

Fixed in commit 634320e. See pull request 344