vermiculus / sx.el

Stack Exchange for Emacs
http://stackapps.com/q/3950
709 stars 40 forks source link

`sx_authenticate` redirects to a "not valid uri" #349

Open RockyRoad29 opened 6 years ago

RockyRoad29 commented 6 years ago

I was not able to get an OAuth token M-x sx-authenticate sends me to uri (I obliterated here the client-id) https://stackoverflow.com/oauth/dialog?client_id=####&redirect_uri=http%253A%252F%252Fseanallred.com%252Fsx.el%252Fauth%252Fauth.htm&scope=read_inbox%2cno_expiry%2cprivate_info%2cwrite_access. The server answers: http%3A%2F%2Fseanallred.com%2Fsx.el%2Fauth%2Fauth.htm is not a valid uri

I think the redirect_uri looks like encoded twice.

RockyRoad29 commented 6 years ago

This PR #350 fixed it for me. But for some reason CI fails. I leave it to you from here.

basil-conto commented 6 years ago

Aren't this issue and the related PR #350 duplicates of #342?

unhammer commented 5 years ago

in melpa-stable 0.4 I got Could not parsed uri [http%3A%2F%2Fseanallred.com%2Fsx.el%2Fauth%2Fauth.htm].

I upgraded to (unstable) melpa 20190114.1523 and it seems to be working there.

(edited for clarity)

vermiculus commented 5 years ago

I've not yet made a release (and I don't plan to for some time as time is scarce). Are you able to apply any necessary patches locally or (probably better) switch to using MELPA or some system that pulls HEAD?

basil-conto commented 5 years ago

@RockyRoad29 Can you still reproduce this issue?

matthew-piziak commented 5 years ago

@vermiculus Fixed for me now! Thank you!