search

vermiculus / sx.el

Stack Exchange for Emacs
http://stackapps.com/q/3950
709 stars 40 forks source link

fixing issue #349 #350

Closed RockyRoad29 closed 6 years ago

RockyRoad29 commented 6 years ago

Here's a quick fix for the new issue I just reported. I noticed an extra access right in token scope, compared to documentation. Let's be fair, document it, or remove it if not used. As I'm not familiar with lisp macros, I left the comma, I don't know if it is needed.

iocanel commented 6 years ago

@vermiculus: This pull request completely fixed the issue for me. Also, the fact that ci breaks, is because there is a global issue with emacs and docker and most ci for emacs plugins I see these days seem to be broken.

vermiculus commented 6 years ago

I'm not too concerned about CI right now; I've just been busy lately ☹️ I'm knees-deep into wedding planning (plus other work commitments) so I've not had the time to keep up on my projects.

This looks safe enough though so I'll go ahead and merge.

For reference, the , syntax, when inside the ` syntax, evaluates the form it precedes. So, the form `(lots (of (data ,here))), where here evaluates to 5 (say), will evaluate to (lots (of (data 5))). So you did the right thing to leave in the comma.