vermule / gtalksms

Automatically exported from code.google.com/p/gtalksms
0 stars 0 forks source link

Doesn't always reconnect as network comes up #72

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Disable 'connect on wifi' and 'disconnect on no wifi' preferences.  Enable 
'Stop when charge disconnects' preference.
2. Disable 3g, enable wifi, connect gtalksms
3. Disconnect wifi
4. Connect wifi

What is the expected output? What do you see instead?
* Step 3 puts gtalksms into a 'waiting' state.  Step 4 has no effect (ie, 
gtalksms remains waiting).  Expect to see gtalksms reconnect.

For some reason, the network receiver checks the preference 
'stopOnPowerDisconnected' - this seems wrong - the preferences relating to the 
power/charger state should not affect the network connectivity management.  
Attaching a bundle.

Original issue reported on code.google.com by skippy.hammond@gmail.com on 3 Feb 2011 at 6:55

Attachments:

GoogleCodeExporter commented 9 years ago
Oups in fact it's a stopOnWifiDisconnected... I'll correct this...

Original comment by Florent....@gmail.com on 3 Feb 2011 at 6:42

GoogleCodeExporter commented 9 years ago
Is the inverted boolean in the third case needed at all? If it's true, we will 
land in case 2, if its false, we will land in case 3, with or without it. Or am 
I missing something?

Original comment by fschm...@gmail.com on 3 Feb 2011 at 6:49

GoogleCodeExporter commented 9 years ago
Yes no need at all.

Original comment by Florent....@gmail.com on 3 Feb 2011 at 7:00

GoogleCodeExporter commented 9 years ago

Original comment by Florent....@gmail.com on 3 Feb 2011 at 7:02

GoogleCodeExporter commented 9 years ago
Fixed in v1.9

Original comment by Florent....@gmail.com on 6 Feb 2011 at 8:27

GoogleCodeExporter commented 9 years ago

Original comment by fschm...@gmail.com on 25 Aug 2011 at 7:51