Xa2 instructions - Githubissues

vermut / sailfish-signature-spoofing

This is a compiled set of instructions and tools wrapped in Docker image to fetch, deodex, patch and upload back AlienDalvik files on Sailfish phones

14 stars 12 forks source link

Xa2 instructions #4

Closed AlexEdimensionz closed 5 years ago

AlexEdimensionz commented 5 years ago

IP tables command can't be executed if rsync already running. Reversed the order
The revert process is different (easier) for t he XA2

rfvermut commented 5 years ago

I'm reluctant of merging XA2 specific code here.

I cannot test is right now
It's already a bit of the mess with --env LXC and if's inside code

What I propose:

This repo stays as pure Android 4.4 patch and I will update README to reflect it
@yeoldegrove fork will focus on new Android 8.1 LXC and remove everything non-LXC
We build and publish docker images into DockerHub. Because I feel git submodules and internal make introduce unnecessary complications for users, and my goal was to make it as simple as ever possible.

@yeoldegrove WDYT?

AlexEdimensionz commented 5 years ago

My pull request doesn't remove the existing instructions. i added a section at the bottom for XA2

yeoldegrove commented 5 years ago

@AlexEdimensionz You can create a PR against https://github.com/yeoldegrove/sailfish-signature-spoofing-lxc against the master branch. We can merge this there.

@rfvermut I like your idea of splitting it up... Makes it more easy to maintain.

rfvermut commented 5 years ago

@yeoldegrove what would be the good telltale of LXC environment? So I can add it to script like

if [[ -f /etc/LXC ]]; then
  echo "Seems like you are using tool for older Android version. Please use yeoldegrove/sailfish-signature-spoofing-lxc"
  echo "https://github.com/yeoldegrove/sailfish-signature-spoofing-lxc"
  exit 1
fi

yeoldegrove commented 5 years ago

@rfvermut test -f /var/lib/lxc/aliendalvik/config should be enough

By the way... Funny this is going so fast and we both already have everything up and running ;)

yeoldegrove commented 5 years ago

@AlexEdimensionz I opened a new PR for you here: https://github.com/yeoldegrove/sailfish-signature-spoofing-lxc/pull/7

rfvermut commented 5 years ago

Nothing can stop SFOS.

I added simple validation: https://github.com/vermut/sailfish-signature-spoofing/commit/f35aa89e2e49e7c61db3699c0931acc07ae51388#diff-1b0c2b516b83393edb7200ad5ff12181R6