search

vernemq / docker-vernemq

VerneMQ Docker image - Starts the VerneMQ MQTT broker and listens on 1883 and 8080 (for websockets).
https://vernemq.com
Apache License 2.0
178 stars 231 forks source link

fix: allow LoadBalancer type for api service #365

Closed mgagliardo91 closed 11 months ago

mgagliardo91 commented 12 months ago

The goal of this PR is to mimic how we allow different Service types for the isolated API service, rather than forcing a ClusterIP type.

mgagliardo91 commented 12 months ago

@ioolkos we would like to enable our API service as a LoadBalancer type so we can provide it an internal DNS name with AWS ALB - would you mind taking a look?

ioolkos commented 11 months ago

@mgagliardo91 thanks, this looks backward compatible to me, would you agree? if yes, looks good to me to merge.

mgagliardo91 commented 11 months ago

@mgagliardo91 thanks, this looks backward compatible to me, would you agree? if yes, looks good to me to merge.

Yes, the change should have no impact with default values.