search

vernemq / plumtree

Epidemic Broadcast Trees
Apache License 2.0
6 stars 8 forks source link

WIP: Limit outstanding messages #12

Closed dergraf closed 6 years ago

dergraf commented 7 years ago

@larshesel can you check the memory and plumtree behaviour with your netsplit scenario?

larshesel commented 7 years ago

I did some tests where I had a 3 node cluster, allowed netsplit actions and anonymous clients. I'd hardcoded the outstanding set to 10 elements. I then removed stopped one node from the cluster and then subscribed to 13 different topics from 13 different clients on one of the remaining nodes and saw that the contents of the outstanding set in plutree_broadcast did not contain all the events (some had been dropped). Then I restarted the stopped node and all data was replicated as expected: all subscriptions of the 13 clients showed up in the vmq_trie_remote_subs table.

I think some systematic tests along these lines should be added, also to make it possible to test this on a larger scale.

larshesel commented 7 years ago

Removed this comment as it wasn't true (self-sensorship). All the plumtree tests pass, also with outstanding_limit set to 10.