vernemq / rebar3_cuttlefish

Cuttlefish plugin for rebar3
Other
26 stars 37 forks source link

Merge basho/rebar3_cuttlefish:develop #47

Closed aef- closed 1 year ago

aef- commented 1 year ago

This is essentially https://github.com/vernemq/rebar3_cuttlefish/pull/37 with additional updates and commit history from Basho's version. I'm happy to reconcile changes between this and #37 if we're able to get #37 merged in.

ioolkos commented 1 year ago

@aef- Thanks! I'm not against merging history in. (but have not yet looked at the commits) It absolutely must not break the VerneMQ release builds, though! :smile: As an example, Verne does currently not use the extended_bin_script.

aef- commented 1 year ago

Thanks ioolkos, I gotcha! I diff'd the generated bin scripts with both versions and there isn't a difference. This is because you all are using template overlay without generate_start_script. I think, then, line 97 is the only difference, as the rest are essentially behind flags that are disabled by default so they should not affect your output. Let me know, I'll make w/e changes necessary to get this merged in.

ioolkos commented 1 year ago

@aef- Thanks. I just run a local build test for Verne, with your rebar3_cuttlefish PR in a _checkouts dir, so that the plugin is taken locally from there. Seems it does not break nodetool/vernemq/vmq-admin scripts, so looks good so far.

ioolkos commented 1 year ago

@aef- I'm merging this, somewhat guerilla style. It doesn't seem to break Verne builds but my thinking is that the merge will surface any issues with that rather quickly, in any case.

aef- commented 1 year ago

Sounds good @ioolkos!