search

vernes / YiiMailer

Yii extension for sending emails with layouts using PHPMailer
81 stars 38 forks source link

PHP 7.x compatibility? #38

Open nikolasr200 opened 6 years ago

nikolasr200 commented 6 years ago

Hi,

are there any upcoming changes regrding PHP 7.x compatibility? perhaps remove Exceptions and replace them with Throwable etc?

8odoris commented 6 years ago

I am interested in this update. I want to use it at Yii 1.1 project.

vernes commented 6 years ago

Hi. I'm not actively developing this anymore, but there is no reason not to at least make it compatible with 7.2. So, I'll see what I can do

nikolasr200 commented 6 years ago

Thanks a lot @vernes you ve already done a great job, and since Yii, has been updated to support PHP 7.2 it would be great to see extensions that are widely used to be updated as well. Looking forward to hearing from you.

vernes commented 6 years ago

Do you have any specific PHP7 compatibility errors? I checked it and it works fine on php 7.2.

I don't want to introduce any breaking changes, this library is in maintenance mode and as for yii1.1, should not be used for new projects anyway.

nikolasr200 commented 6 years ago

There aren’t indeed any specific 7.2 errors as I noticed as well, just a little curious if it would worth

a) updating the exception declarence over the dummy method where email is stored as eml, b) updating dependence with phpmailer which I think holds more deprecated exceptions