search

veromary / divinum-officium

Automatically exported from code.google.com/p/divinum-officium
0 stars 0 forks source link

Spurious headings in special-format offices #230

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
A) 
http://divinumofficium.com/cgi-bin/horas/Pofficium.pl?command=prayMatutinum&date
1=11-3-2014&version=Rubrics%201960&lang2=English
B) 
http://divinumofficium.com/cgi-bin/horas/Pofficium.pl?command=prayPrima&date1=4-
6-2012&version=Rubrics%201960

What is the expected output? What do you see instead?
A) Since there is no conclusion, there should not be a Conclusio/Finish heading 
at the end. Instead this now appears.
B) The "Orationes" heading appears twice (first "{specialis}", then "{ex 
Proprio de Tempore}"). Previously, only the first of these appeared.

Please provide any additional information below.
Case (A) is All Souls Day; case (B) is the office of Prime during the triduum. 
Both of these are special-case offices.

In both cases, this worked properly up until r2099, and broke in r2100. There 
seems to be some flaw in the refactoring that created Scripting.pm.

In addition, when I run the script from the command line to check for this 
problem, I get numerous warnings from sub parse_script_arguments (this is where 
line 110 is in r2100):
perl ./web/cgi-bin/horas/Pofficium.pl 
'command=prayMatutinum&date1=11-3-2014&version=Rubrics%201960' | grep Conclusio
[Sat Mar 22 19:32:14 2014] Pofficium.pl: Use of uninitialized value in split at 
/Users/jlm/Code/my-divinum-officium/web/cgi-bin/horas/../horas/Scripting.pm 
line 110.
[Sat Mar 22 19:32:14 2014] Pofficium.pl: Use of uninitialized value in split at 
/Users/jlm/Code/my-divinum-officium/web/cgi-bin/horas/../horas/Scripting.pm 
line 110.
...

I don't get any warnings about uninitialized values with r2099.

Original issue reported on code.google.com by a...@liturgiaetmusica.com on 22 Mar 2014 at 8:03

GoogleCodeExporter commented 9 years ago 
Above I used Good Friday 2012, because that's in my set of test cases. However, 
the problem also occurs this year. The first day that the error will appear in 
the office is on Holy Thursday, April 17.

http://divinumofficium.com/cgi-bin/horas/Pofficium.pl?command=prayPrima&date1=4-
17-2014&version=Rubrics%201960

Original comment by a...@liturgiaetmusica.com on 22 Mar 2014 at 8:07

GoogleCodeExporter commented 9 years ago 
Thanks for the report. This was a latent bug: both headings were always 
generated, but the second ones were suppressed as a side-effect of the 
reference-expansion mechanism. I'll work on a fix.

Original comment by igregord on 26 Mar 2014 at 10:49

GoogleCodeExporter commented 9 years ago

Original comment by igregord on 26 Mar 2014 at 10:49

GoogleCodeExporter commented 9 years ago 
Fixed by revisions r2161, r2162 and r2163.

Original comment by igregord on 29 Mar 2014 at 3:03