stepan
commented
10 years ago :+1: nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. A few notes after checking out the code:
- Be sure to follow the Objective-C code styling conventions for the homework. The New York Times has a good summary of appropriate Objective-C coding conventions, you should take a quick look here.
- Nice work with the header files. You should always try to minimize the number of properties and methods in the header files and move all private properties and methods into the class extension (the @interface block in the .m file).
- Your project should include a Movie model that can deserialize from an NSDictionary.
- Your custom Movie cell should have a property called
movie. In the custom setter ofmovie, you should configure the various labels and images. This decouples your custom cells from the table view controllers. - Use
[tableView dequeueReusableCellWithIdentifier:forIndexPath:]method which gurantees to return a valid cell. - Nice work loading the images asynchronously.
- Note that your images are stretched. You should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
- Nice work implementing the error message on network failure.
- In general, you should challenge yourself to create visually polished applications. That's where you'll find all the rough edges of the iOS framework and earn the next level of mastery.
My project is here. I am not quite sure the cache part is correct. Please take a look. /cc @timothy1ee @thecodepath