search

veronicacannon / stylist

Rails App for Alycia the Stylist
4 stars 2 forks source link

Update to AppointmentMailer #26

Closed Seberius closed 10 years ago

Seberius commented 10 years ago

The two appointment mailer class have been merged. The subject has been changed to use config.stylist_name which should be added to config/environments/development.rb, along with config.from_email_address, for testing. The templates by @veronicacannon have been renamed for the new method name and duplicated for the to_stylist mailer method. If different templates are wanted for the stylist emails the templates will need to be updated.

elskwid commented 10 years ago

I only had a question about the to address above. Other than that it looks good to me.

Seberius commented 10 years ago

I named that config for the from default field and then copy pasted it to the to field because it was the same address. I will add config.stylist_email_address in the to_stylist method so it makes more sense. That way the config.from_email_address could be something like no-reply@example.com.

elskwid commented 10 years ago

Perfect.

Seberius commented 10 years ago

I used the recent merge on master of as a chance to try rebasing a branch. The commits for this branch were all squashed into e0a0220 and rebased from 108a6e0 to d08f44c.

veronicacannon commented 10 years ago

Thanks for the work, Kaijah!

veronicacannon commented 10 years ago

Nice job on the additions for generic stylist, Kaijah. You did great.

From: Seberius [mailto:notifications@github.com] Sent: Sunday, April 27, 2014 1:14 PM To: veronicacannon/stylist Cc: Veronica Cannon Subject: Re: [stylist] Update to AppointmentMailer (#26)

I used the recent merge on master of as a chance to try rebasing a branch. The commits for this branch were all squashed into e0a0220https://github.com/veronicacannon/stylist/commit/e0a0220 and rebased from 108a6e to d08f44.

— Reply to this email directly or view it on GitHubhttps://github.com/veronicacannon/stylist/pull/26#issuecomment-41507506.

Seberius commented 10 years ago

I added a new branch called fix-mailer with a few fixes.