verot / class.upload.php

This PHP class uploads files and manipulates images very easily. It is in fact as much as an image processing class than it is an upload class. Compatible with PHP 4, 5, 7 and 8. Supports processing of local files, uploaded files, files sent through XMLHttpRequest.
http://www.verot.net/php_class_upload.htm
GNU General Public License v2.0
854 stars 359 forks source link

PHP 8.1 #157

Closed Shou-nen closed 2 years ago

Shou-nen commented 2 years ago

Is there a problem on PHP 8.1?

E_DEPRECATED | line 4042 | Implicit conversion from float 237.4 to int loses precision E_DEPRECATED | line 4042 | Implicit conversion from float 235.4 to int loses precision

verot commented 2 years ago

I cannot test on 8.1 right now. But this warning is not too problematic. The values should be explicitely cast as integer rather than implicitely converted, but the class will work just as well.

verot commented 2 years ago

I don't manage to replicate the issue. Do you have some test code and test image I can try?

wintstar commented 2 years ago

I use class.upload.php under PHP Version 8.1.8 and have no entries in the error log of the server.

verot commented 2 years ago

I use class.upload.php under PHP Version 8.1.8 and have no entries in the error log of the server.

What do you mean? What entries do you expect in the error log?

wintstar commented 2 years ago

I will say, i have no problems with php 8.1. No errors.

verot commented 2 years ago

Should be now fixed with 456535b