"Failed to load magic database"

Shou-nen commented 2 years ago

On my xampp local server when uploading an image:

The specified folder not exist and I can't see at all any folder named "magic' in my xampp, so the function probably shouldn't try to open it.

verot commented 2 years ago

The class should work on Windows, but it not supported. However, I will gladly accept a patch fixing this issue.

Shou-nen commented 2 years ago

Hmm, maybe just add checking if the folder exists in line 2451?

if ($path) { -> if ($path && file_exists($path)) {

emondpph commented 2 years ago

Yeah, I just stumbled on the same problem running my test suite on Windows... It seems you are trying to load a magic file which is internal in PHP 8.1 Windows and not required. The file_exists($path) should fix it.

Incredible class you did by the way, still useful a decade after.

verot commented 2 years ago

Hopefully fixed in 5a22579. Does it work with 8.1 on Windows? Would you be kind enough as to provide a log of an upload?

emondpph commented 2 years ago

system information

class version : 03/08/2019
operating system : WINNT
PHP version : 8.1.4
GD version : 2.1.0
supported image types : png webp jpg gif bmp
open_basedir : no restriction
upload_max_filesize : 40M (41943040 bytes)
language : en_GB source is a local file C:/Users/PG/Desktop/project/storage/public/media/assert/jpg.jpg
local file OK determining MIME type
Checking MIME type with Fileinfo PECL extension MAGIC path defaults to C:\xampp\php/extras/magic MAGIC path will not be used MIME type detected as image/jpeg; charset=binary by Fileinfo PECL extension
MIME validated as image/jpeg source variables
You can use all these before calling process() file_src_name : jpg.jpg file_src_name_body : jpg file_src_name_ext : jpg file_src_pathname : C:/Users/PG/Desktop/project/storage/public/media/assert/jpg.jpg file_src_mime : image/jpeg file_src_size : 4210 (max= 41943040) file_src_error : 0
source file is an image image_src_x : 2 image_src_y : 2 image_src_pixels : 4 image_src_type : jpg image_src_bits : 8 process file to C:/Users/PG/Desktop/project/storage/public/storage/ormCell/1/thumbnail/0\
file size OK
file mime OK : image/jpeg
new file name body : jpg
destination variables file_dst_path : C:/Users/PG/Desktop/project/storage/public/storage/ormCell/1/thumbnail/0\ file_dst_name_body : jpg file_dst_name_ext : jpg
no auto_rename if same filename exists
destination file details file_dst_name : jpg.jpg file_dst_pathname : C:/Users/PG/Desktop/project/storage/public/storage/ormCell/1/thumbnail/0\jpg.jpg
jpg.jpg doesn't exist already
EXIF data is invalid or missing
no image processing wanted
process OK system information
class version : 03/08/2019
operating system : WINNT
PHP version : 8.1.4
GD version : 2.1.0
supported image types : png webp jpg gif bmp
open_basedir : no restriction
upload_max_filesize : 40M (41943040 bytes)
language : en_GB source is a local file C:/Users/PG/Desktop/project/storage/public/storage/ormCell/1/thumbnail/0/jpg.jpg
local file OK determining MIME type
Checking MIME type with Fileinfo PECL extension MAGIC path defaults to C:\xampp\php/extras/magic MAGIC path will not be used MIME type detected as image/jpeg; charset=binary by Fileinfo PECL extension
MIME validated as image/jpeg source variables
You can use all these before calling process() file_src_name : jpg.jpg file_src_name_body : jpg file_src_name_ext : jpg file_src_pathname : C:/Users/PG/Desktop/project/storage/public/storage/ormCell/1/thumbnail/0/jpg.jpg file_src_mime : image/jpeg file_src_size : 4210 (max= 41943040) file_src_error : 0
source file is an image image_src_x : 2 image_src_y : 2 image_src_pixels : 4 image_src_type : jpg image_src_bits : 8 process file to C:/Users/PG/Desktop/project/storage/public/storage/ormCell/1/thumbnail/large\
file size OK
file mime OK : image/jpeg
new file name ext : jpg
new file name body : jpg
destination variables file_dst_path : C:/Users/PG/Desktop/project/storage/public/storage/ormCell/1/thumbnail/large\ file_dst_name_body : jpg file_dst_name_ext : jpg
no auto_rename if same filename exists
destination file details file_dst_name : jpg.jpg file_dst_pathname : C:/Users/PG/Desktop/project/storage/public/storage/ormCell/1/thumbnail/large\jpg.jpg
jpg.jpg doesn't exist already
auto-rotate deactivated
image resizing or conversion wanted
source image is JPEG
resizing... ratio_crop_y : 300 (150;150) image_src_x y : 2 x 2 image_dst_x y : 600 x 600 resized image object created
crop image : 150 0 150 0
converting... fills in transparency with default color
saving image... JPEG image created image objects destroyed
process OK system information
class version : 03/08/2019
operating system : WINNT
PHP version : 8.1.4
GD version : 2.1.0
supported image types : png webp jpg gif bmp
open_basedir : no restriction
upload_max_filesize : 40M (41943040 bytes)
language : en_GB source is a local file C:/Users/PG/Desktop/project/storage/public/media/assert/jpg.jpg
local file OK determining MIME type
Checking MIME type with Fileinfo PECL extension MAGIC path defaults to C:\xampp\php/extras/magic MAGIC path will not be used MIME type detected as image/jpeg; charset=binary by Fileinfo PECL extension
MIME validated as image/jpeg source variables
You can use all these before calling process() file_src_name : jpg.jpg file_src_name_body : jpg file_src_name_ext : jpg file_src_pathname : C:/Users/PG/Desktop/project/storage/public/media/assert/jpg.jpg file_src_mime : image/jpeg file_src_size : 4210 (max= 41943040) file_src_error : 0
source file is an image image_src_x : 2 image_src_y : 2 image_src_pixels : 4 image_src_type : jpg image_src_bits : 8 process file to C:/Users/PG/Desktop/project/storage/public/storage/ormCell/1/thumbnails/2/0\
file size OK
file mime OK : image/jpeg
new file name body : jpg
destination variables file_dst_path : C:/Users/PG/Desktop/project/storage/public/storage/ormCell/1/thumbnails/2/0\ file_dst_name_body : jpg file_dst_name_ext : jpg
no auto_rename if same filename exists
destination file details file_dst_name : jpg.jpg file_dst_pathname : C:/Users/PG/Desktop/project/storage/public/storage/ormCell/1/thumbnails/2/0\jpg.jpg
jpg.jpg doesn't exist already
EXIF data is invalid or missing
no image processing wanted
process OK system information
class version : 03/08/2019
operating system : WINNT
PHP version : 8.1.4
GD version : 2.1.0
supported image types : png webp jpg gif bmp
open_basedir : no restriction
upload_max_filesize : 40M (41943040 bytes)
language : en_GB source is a local file C:/Users/PG/Desktop/project/storage/public/storage/ormCell/1/thumbnails/2/0/jpg.jpg
local file OK determining MIME type
Checking MIME type with Fileinfo PECL extension MAGIC path defaults to C:\xampp\php/extras/magic MAGIC path will not be used MIME type detected as image/jpeg; charset=binary by Fileinfo PECL extension
MIME validated as image/jpeg source variables
You can use all these before calling process() file_src_name : jpg.jpg file_src_name_body : jpg file_src_name_ext : jpg file_src_pathname : C:/Users/PG/Desktop/project/storage/public/storage/ormCell/1/thumbnails/2/0/jpg.jpg file_src_mime : image/jpeg file_src_size : 4210 (max= 41943040) file_src_error : 0
source file is an image image_src_x : 2 image_src_y : 2 image_src_pixels : 4 image_src_type : jpg image_src_bits : 8 process file to C:/Users/PG/Desktop/project/storage/public/storage/ormCell/1/thumbnails/2/large\
file size OK
file mime OK : image/jpeg
new file name ext : jpg
new file name body : jpg
destination variables file_dst_path : C:/Users/PG/Desktop/project/storage/public/storage/ormCell/1/thumbnails/2/large\ file_dst_name_body : jpg file_dst_name_ext : jpg
no auto_rename if same filename exists
destination file details file_dst_name : jpg.jpg file_dst_pathname : C:/Users/PG/Desktop/project/storage/public/storage/ormCell/1/thumbnails/2/large\jpg.jpg
jpg.jpg doesn't exist already
auto-rotate deactivated
image resizing or conversion wanted
source image is JPEG
resizing... ratio_crop_y : 300 (150;150) image_src_x y : 2 x 2 image_dst_x y : 600 x 600 resized image object created
crop image : 150 0 150 0
converting... fills in transparency with default color
saving image... JPEG image created image objects destroyed
process OK system information
class version : 03/08/2019
operating system : WINNT
PHP version : 8.1.4
GD version : 2.1.0
supported image types : png webp jpg gif bmp
open_basedir : no restriction
upload_max_filesize : 40M (41943040 bytes)
language : en_GB source is a local file C:/Users/PG/Desktop/project/storage/public/media/assert/jpg.jpg
local file OK determining MIME type
Checking MIME type with Fileinfo PECL extension MAGIC path defaults to C:\xampp\php/extras/magic MAGIC path will not be used MIME type detected as image/jpeg; charset=binary by Fileinfo PECL extension
MIME validated as image/jpeg source variables
You can use all these before calling process() file_src_name : jpg.jpg file_src_name_body : jpg file_src_name_ext : jpg file_src_pathname : C:/Users/PG/Desktop/project/storage/public/media/assert/jpg.jpg file_src_mime : image/jpeg file_src_size : 4210 (max= 41943040) file_src_error : 0
source file is an image image_src_x : 2 image_src_y : 2 image_src_pixels : 4 image_src_type : jpg image_src_bits : 8 process file to C:/Users/PG/Desktop/project/storage/public/storage/ormCell/1/thumbnails/4/0\
file size OK
file mime OK : image/jpeg
new file name body : jpg
destination variables file_dst_path : C:/Users/PG/Desktop/project/storage/public/storage/ormCell/1/thumbnails/4/0\ file_dst_name_body : jpg file_dst_name_ext : jpg
no auto_rename if same filename exists
destination file details file_dst_name : jpg.jpg file_dst_pathname : C:/Users/PG/Desktop/project/storage/public/storage/ormCell/1/thumbnails/4/0\jpg.jpg
jpg.jpg doesn't exist already
EXIF data is invalid or missing
no image processing wanted
process OK system information
class version : 03/08/2019
operating system : WINNT
PHP version : 8.1.4
GD version : 2.1.0
supported image types : png webp jpg gif bmp
open_basedir : no restriction
upload_max_filesize : 40M (41943040 bytes)
language : en_GB source is a local file C:/Users/PG/Desktop/project/storage/public/storage/ormCell/1/thumbnails/4/0/jpg.jpg
local file OK determining MIME type
Checking MIME type with Fileinfo PECL extension MAGIC path defaults to C:\xampp\php/extras/magic MAGIC path will not be used MIME type detected as image/jpeg; charset=binary by Fileinfo PECL extension
MIME validated as image/jpeg source variables
You can use all these before calling process() file_src_name : jpg.jpg file_src_name_body : jpg file_src_name_ext : jpg file_src_pathname : C:/Users/PG/Desktop/project/storage/public/storage/ormCell/1/thumbnails/4/0/jpg.jpg file_src_mime : image/jpeg file_src_size : 4210 (max= 41943040) file_src_error : 0
source file is an image image_src_x : 2 image_src_y : 2 image_src_pixels : 4 image_src_type : jpg image_src_bits : 8 process file to C:/Users/PG/Desktop/project/storage/public/storage/ormCell/1/thumbnails/4/large\
file size OK
file mime OK : image/jpeg
new file name ext : jpg
new file name body : jpg
destination variables file_dst_path : C:/Users/PG/Desktop/project/storage/public/storage/ormCell/1/thumbnails/4/large\ file_dst_name_body : jpg file_dst_name_ext : jpg
no auto_rename if same filename exists
destination file details file_dst_name : jpg.jpg file_dst_pathname : C:/Users/PG/Desktop/project/storage/public/storage/ormCell/1/thumbnails/4/large\jpg.jpg
jpg.jpg doesn't exist already
auto-rotate deactivated
image resizing or conversion wanted
source image is JPEG
resizing... ratio_crop_y : 300 (150;150) image_src_x y : 2 x 2 image_dst_x y : 600 x 600 resized image object created
crop image : 150 0 150 0
converting... fills in transparency with default color
saving image... JPEG image created image objects destroyed
process OK

emondpph commented 2 years ago

It did fix my issue... I cannot say if the whole class is working as I am only using the resizing and compressing options. Thank you.

verot commented 2 years ago

It should be fine. The important line is "MIME type detected as image/jpeg; charset=binary by Fileinfo PECL extension" which indicates that on PHP 8.1, even though it cannot find the magic file, it manages to use the built-in one. Thank you!

verot / class.upload.php

"Failed to load magic database" #158