verpas / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

msvs 2010 generator relativizes the path of some source files multiple times #201

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
We have discovered the following problem in our work on skia 
(http://code.google.com/p/skia/):

When generating the .vcxproj files (with GYP_MSVS_VERSION=2010), some source 
paths are "rerelativized" (modified to be relative to the supposed current 
working directory) more than once, so that the path ends up being erroneous.

Unfortunately, I cannot give steps to reproduce the problem except within the 
Skia code.  I will try to add a test that exercises this within the gyp tests, 
and ultimately submit a fix...

In the meanwhile, here's how to reproduce within skia, on Windows (not cygwin):
svn co -r 1847 http://skia.googlecode.com/svn/trunk skia-read-only
cd skia-read-only
make tests

You will see a bunch of errors about missing header files.  If you open up one 
of the .vcxproj files (e.g., skia-read-only\out\gyp\tests.vcxproj), you will 
see that the paths in AdditionalIncludeDirectories are invalid (many of the 
directory paths are at the wrong depth, with too many "../")

In http://codereview.chromium.org/7210040/ , I have created a new 
msvs_abspath_output generator_flag.  When set, gyp outputs absolute paths 
rather than relative paths, to avoid this bug; by default, the old behavior 
remains in place.

Original issue reported on code.google.com by epoger@google.com on 13 Jul 2011 at 5:56