search

versat / cntlm

Cntlm is an NTLM / NTLM Session Response / NTLMv2 authenticating HTTP proxy intended to help you break free from the chains of Microsoft proprietary world. More info on http://cntlm.sourceforge.net/ website. This version also supports: SSPI (on Windows, NTLM authentication only), Kerberos authentication, IPv6, proxy PAC files.
GNU General Public License v2.0
118 stars 41 forks source link

Use a single Makefile for all compilers #104

Closed fralken closed 4 months ago

fralken commented 4 months ago

Using a custom Makefile for each compiler has a few drawbacks. We need to maintain more files, but also we must explicitly invoke ./configure before make. This is because ./configure selects the compiler and moves and renames the correct Makefile. Makefile is able to invoke ./configure but this correctly works only for gcc because, being the default, the Makefile is already in place. For other compilers the one for gcc would be incorrectly used.

This PR uses a single Makefile with conditional configurations based on the selected compiler. It uses configure-stamp to store the compiler name. In the Makefile the first command is checking the existence of this file and invoke ./configure if it is missing. This also simplifies ./configure because we can remove the logic of renaming makefiles.

I also silenced compiler verbosity to make it easier to spot compiler warnings.

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud