search

versat / cntlm

Cntlm is an NTLM / NTLM Session Response / NTLMv2 authenticating HTTP proxy intended to help you break free from the chains of Microsoft proprietary world. More info on http://cntlm.sourceforge.net/ website. This version also supports: SSPI (on Windows, NTLM authentication only), Kerberos authentication, IPv6, proxy PAC files.
GNU General Public License v2.0
127 stars 40 forks source link

Add Release Action #108

Closed SunNathan closed 7 months ago

SunNathan commented 7 months ago

This PR adds:

(To activate the build, simply create a tag, and artifacts will be added automatically).

If you have any questions or suggestions for improvement, feel free to ask!

Here's a sample result: Annotation 2024-03-05 092113

(close #71)

versat commented 7 months ago

@fralken This looks great to me. You also played around with release workflows, what do you think?

fralken commented 7 months ago

Yes last year I made a release workflow. It is a single file using the matrix strategy. I didn't merge it here because my idea was also to add a release for macOS but then I never found time to investigate on it. I'm not sure if it is better to have a single workflow file dedicated to all the releases or a workflow file for each platform.

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

fralken commented 7 months ago

It looks good to me, too. It can be merged. Thanks a lot for this.

Anyway, I would wait creating a tag triggering the release until @gs-kamnas completes PR #97