versatica / JsSIP

JsSIP, the JavaScript SIP library
https://jssip.net
Other
2.4k stars 739 forks source link

Change type of request in OutgoingRTCSessionEvent to OutgoingRequest #821

Closed SergioFatalist closed 7 months ago

SergioFatalist commented 1 year ago

Hi! πŸ‘‹

Firstly, thanks for your work on this project! πŸ™‚

Today I used patch-package to patch jssip@3.10.0 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/jssip/lib/UA.d.ts b/node_modules/jssip/lib/UA.d.ts
index 13798d3..1e51f3d 100644
--- a/node_modules/jssip/lib/UA.d.ts
+++ b/node_modules/jssip/lib/UA.d.ts
@@ -55,7 +55,7 @@ export interface IncomingRTCSessionEvent {
 export interface OutgoingRTCSessionEvent {
   originator: Originator.LOCAL;
   session: RTCSession;
-  request: IncomingRequest;
+  request: OutgoingRequest;
 }

 export type RTCSessionEvent = IncomingRTCSessionEvent | OutgoingRTCSessionEvent;

This issue body was partially generated by patch-package.

AlijiEmmanuel-dev commented 8 months ago

I was just about to report this issue. It has not been fixed.

ibc commented 7 months ago

Fixed in https://github.com/versatica/JsSIP/pull/846