versatica / JsSIP

JsSIP, the JavaScript SIP library
https://jssip.net
Other
2.4k stars 739 forks source link

feat: fire sipEvent on RTCSession when STATUS_WAITING_FOR_ANSWER #833

Closed wangduanduan closed 1 year ago

wangduanduan commented 1 year ago

when jssip receivce NOTIFY (in dialog) before call answer, jssip reply with 403 Wrong Status.

but we want to use in-dialog NOTIFY

the code below is my in app , no in jssip

myPhone.on('newRTCSession', ({ session, originator, request })=>{

    session.on('sipEvent', (e) => {

    })
})
markusatm commented 1 year ago

There's already a pending pull request I created for this two years ago: #748 I recommend using that one since it fully implements it and makes it optional. Always simply accepting a call if a "talk" notify arrives is a security risk.

wangduanduan commented 1 year ago

@markusatm but why they not accepted your pull request for two years! 😂. #748

ibc commented 1 year ago

We will address pending PRs when we are less busy, but indeed this PR is no valid due to above given rationale.

wangduanduan commented 1 year ago

@markusatm

I just need the sipEvent in dialog, maybe not answer call