versatica / JsSIP

JsSIP, the JavaScript SIP library
https://jssip.net
Other
2.4k stars 739 forks source link

Fixed some broken TypeScript definitions in RTCSession.d.ts and UA.d.ts #846

Closed stefang42 closed 7 months ago

stefang42 commented 7 months ago

This commit fixes some type definitions that unfortunately were broken by some of the recent merges of some pull request.

Commit d547d74be9f757dc23a1065670c8d10515152f17 (Use built-in MediaStreamConstraints type (#809)) removed the interface MediaConstraints, but failed to adjust the definitions of RTCSession's MuteListener and the mute, unmute and isMuted functions. This leads to errors when transpiling with TypeScript: TS2552: Cannot find name MediaConstraints. Did you mean MediaTrackConstraints?

Commit 901574f75e06645776a4fad5793903d3c8488844 (Allow to configure from-tag in register (#793)) introduced UAConfiguration.register_from_tag_trail with an invalid type that causes an error with TypeScript: TS8020: JSDoc types can only be used inside documentation comments.

I also took the opportunity to fix a wrong type definition in OutgoingRTCSessionEvent, for which there is also an open issue #821.

ibc commented 7 months ago

Thanks