versatica / libmediasoupclient

mediasoup client side C++ library
https://mediasoup.org
ISC License
286 stars 177 forks source link

Fix ambiguous cast error when compiling with MSVC #113

Closed maxweisel closed 3 years ago

maxweisel commented 3 years ago

MSVC doesn't understand the implicit cast from json -> std::string, this uses the .get() operator to make it explicit.

ibc commented 3 years ago

Why are things related to Transport::Listener in this PR?

ibc commented 3 years ago

I assume this is because you did your PR from your branch in https://github.com/versatica/libmediasoupclient/pull/112. Please, let's separate them.

maxweisel commented 3 years ago

Fixed! I also went in and updated the CHANGELOG to save you the trouble.

ibc commented 3 years ago

3.1.4 tagged, thanks