versatica / libmediasoupclient

mediasoup client side C++ library
https://mediasoup.org
ISC License
291 stars 178 forks source link

Enable VP9 SVC with webrtc m94 #131

Closed harvestsure closed 2 years ago

harvestsure commented 3 years ago

Enable VP9 SVC with webrtc m94 webrtc::RtpEncodingParameters.scalability_mode

ibc commented 3 years ago

@jmillan anything else from your side? should we merge and release?

ibc commented 3 years ago

@harvestsure I'd appreciate a PR in the mediasoup-website project with updated API documentation.

jmillan commented 3 years ago

@jmillan anything else from your side? should we merge and release?

It looks good to me. I'Il merge it and release tomorrow if you don't do it before.

ibc commented 3 years ago

Sorry for the delay, terribly busy. Will check this in next days but cannot provide with a proper ETA yet.

ibc commented 2 years ago

@jmillan ping

jmillan commented 2 years ago

I'm testing this PR with m89.

jmillan commented 2 years ago

Actually m89 fails to compile with Xcode 13 and it's already very old. I'll try the newest stable branch instead.

jmillan commented 2 years ago

@harvestsure,

You didn't modify the tests, which do not compile. Please, adapt the test files accordingly and also, let me ask you to target this PR against the new libmediasoupclient which uses M94.

harvestsure commented 2 years ago

@harvestsure,

You didn't modify the tests, which do not compile. Please, adapt the test files accordingly and also, let me ask you to target this PR against the new libmediasoupclient which uses M94.

I have compiled using the M94 version with test files.

jmillan commented 2 years ago

There's a warning here @harvestsure,

Screenshot 2021-11-29 at 13 38 08

Also, since this changes the API we'd appreciate a PR in the mediasoup-website project with updated API documentation

harvestsure commented 2 years ago

There's a warning here @harvestsure,

Screenshot 2021-11-29 at 13 38 08

Also, since this changes the API we'd appreciate a PR in the mediasoup-website project with updated API documentation

I'll deal with it later

jmillan commented 2 years ago

Thanks, the doc will be updated.