Closed quanli168 closed 1 year ago
I think sendingRtpParameters should also be updated.
I think sendingRtpParameters should also be updated.
and what exactly needs to be updated do not tell me?
sendingRtpParameters.mid
of course.
sendingRtpParameters.mid
of course.
you correctly noted. But will it work or should the following actions be rewritten too? it might say @ibc
Related issue reported in react-native-webrtc project: https://github.com/react-native-webrtc/react-native-webrtc/issues/1404
Here something I personally hate:
BTW I've reported the issue in react-native-webrtc project: https://github.com/react-native-webrtc/react-native-webrtc/issues/1404
Feedback given in this PR makes sense plus this PR fails at lint task. I'm doing another one here: https://github.com/versatica/mediasoup-client/pull/271
This PR attempts to fix https://github.com/versatica/mediasoup-client/issues/263.
The issue is
transciever.mid
is not available after callingpc.setLocalDescription
. Since mediasoup-client usesmid
as the key to_mapMidTransceiver
map, without a valid mid, future call toproducer.close()
finds wrong transceiver to turn off.After enabling react-native-webrtc logs,I noticed that
transeiver.mid
is properly updated inpc.setRemoteDescription
, therefore I added code to update themid
after the call.