Handlers: check if the handler is closed and call handler methods with await

versatica / mediasoup-client

mediasoup client side JavaScript library

https://mediasoup.org

ISC License

591 stars 237 forks source link

Handlers: check if the handler is closed and call handler methods with await #275

Closed ibc closed 1 year ago

ibc commented 1 year ago

NOTE: Draft PR for now since chnages are only done in Chrome111 handler.

Fixes #274
Add "closed" flag in handlers.
Make some handler methods throw if closed.
Make some other methods return early (without doing anything) if the handler is closed. Yes, methods that close or stop things should be idempotent and never throw.
Transport.ts: use await in all calls to handler methods given to the AwaitQueue.

ibc commented 1 year ago

I've completed other handlers. Not all but just the latest versions. Honestly having to maintain so many old handlers is hell and with the changes in Transport (the addition of those await) the bug is also fixed for all handlers (it's just that some of them may show a warning log, nothing else).