Closed ybybwdwd closed 11 months ago
In request.fbs, the Request.handler_id is required,
Request.handler_id
table Request { id: uint32; method: Method; handler_id: string (required); body: Body; }
but in worker ChannelRequest::ChannelRequest():110 checks if the field exists
ChannelRequest::ChannelRequest():110
// Handler ID is optional. if (flatbuffers::IsFieldPresent(this->data, FBS::Request::Request::VT_HANDLERID)) { this->handlerId = this->data->handlerId()->str(); }
@jmillan I think we can safely remove that check in Worker.cpp, right?
Worker.cpp
Yep, that check can be removed.
EDIT: I'm quite sure, but needs to be checked.
Same applies to ChannelNotification.cpp. On it.
ChannelNotification.cpp
In request.fbs, the
Request.handler_id
is required,but in worker
ChannelRequest::ChannelRequest():110
checks if the field exists