versatica / mediasoup

Cutting Edge WebRTC Video Conferencing
https://mediasoup.org
ISC License
6.27k stars 1.13k forks source link

flatc warning: You should add the boolean check kwarg to the run_command call #1256

Closed ibc closed 11 months ago

ibc commented 11 months ago

Your environment

Issue description

When building and/or running flatc this warning shows up:

Executing subproject flatbuffers

flatbuffers| Project name: flatbuffers
flatbuffers| Project version: 23.3.3
flatbuffers| C++ compiler for the host machine: c++ (gcc 10.2.1 "c++ (Debian 10.2.1-6) 10.2.1 20210110")
flatbuffers| C++ linker for the host machine: c++ ld.bfd 2.35.2
flatbuffers| Checking for function "strtoull_l" : YES (cached)
flatbuffers| Compiler for C++ supports arguments -fsigned-char: YES (cached)
flatbuffers| Build targets in project: 31
flatbuffers| Subproject flatbuffers finished.

Program flatc found: YES (overridden)
WARNING: You should add the boolean check kwarg to the run_command call.
         It currently defaults to false,
         but it will default to true in future releases of meson.
         See also: https://github.com/mesonbuild/meson/issues/9300

This is the related story in Meson: https://github.com/mesonbuild/meson/issues/9300

AFAIU this is not actionable in our side, is it? AFAIS we only call that run_command in our meson.build once. Here:

if host_machine.system() == 'linux' and not get_option('ms_disable_liburing')
  kernel_version = run_command('uname', '-r').stdout().strip()
  // etc

Note that such a warning could be related to any meson.build included by any worker subproject.

ibc commented 11 months ago

Ok, found it. Fixed here: https://github.com/versatica/mediasoup/pull/1255