Make subchannels be ordered

versatica / mediasoup

Cutting Edge WebRTC Video Conferencing

https://mediasoup.org

ISC License

6.27k stars 1.13k forks source link

Make subchannels be ordered #1261

Closed ibc closed 11 months ago

ibc commented 11 months ago

Details

Use an ordered set in DataConsumer in worker so subchannels will be always shown in numerical order (no need to sort them later in Node/Rust layer).
Also make dataConsumer.subchannels be immediately (and optimistically) updated before dataChannel.setSubchannels() completes.

ibc commented 11 months ago

I'm closing this PR since, as @jmillan said, adding addSubchannel() and emoveSubchannel() makes more sense. Also, in other async methods (such as pause()) we don't update this.paused until we get the response fro the worker, so same must be done in setSubchannels().