search

versatica / mediasoup

Cutting Edge WebRTC Video Conferencing
https://mediasoup.org
ISC License
6.18k stars 1.12k forks source link

Rust docs for 0.13 failed to build #1270

Closed PaulOlteanu closed 9 months ago

PaulOlteanu commented 9 months ago

Bug Report

Issue description

The docs for release 0.13 of mediasoup for rust failed to build. Here's a direct link to the error.

I can't really try and help more in depth at the moment, but I do know you can try building docs locally to test the build https://github.com/rust-lang/docs.rs#build-subcommand.

nazar-pc commented 9 months ago

The reason is that we skip the whole build script for build.rs: https://github.com/versatica/mediasoup/blob/f9c081c41e90a84d837d2a26b700d1fee84430c4/worker/build.rs#L5-L8

Now that we have flatbuffers (that we thankfully compile with Rust code) we need to move that check below flatbuffers compilation.

@PaulOlteanu would you mind sending a PR to fix this, please?

ibc commented 9 months ago

To here? https://github.com/versatica/mediasoup/blob/f9c081c41e90a84d837d2a26b700d1fee84430c4/worker/build.rs#L47

nazar-pc commented 9 months ago

Exactly, just move the check there and it should succeed.

ibc commented 9 months ago

https://github.com/versatica/mediasoup/pull/1271