Closed ibc closed 9 months ago
You need to change the workflow to be triggered by release, not tag. And probably exclude rust-*
So you mean that my first commit was way better?
https://github.com/versatica/mediasoup/commit/61a645895c3f2b845f4f8a411a9987811ca58d0a
So you mean that my first commit was way better?
I do think it should have been sufficient, also branches: [v3]
was not necessary there.
BTW you can test how it performs by forking into personal repo and trying some tags/releases, from my experience that is sometimes the only way to find out how it works in practice.
@nazar-pc it looks that branches
and tags
are indeed acumulative, so I'll remove branches
completely:
And yes, I¡ll do this in a fork.
I'm closing this PR and trying things in a personal mediasoup fork. Cosmetic changes done here are now in a separate PR https://github.com/versatica/mediasoup/pull/1281.
@nazar-pc let's follow the discussion and experiments in the issue report: https://github.com/versatica/mediasoup/issues/1243#issuecomment-1871895475
Fixes #1243
While it's true that this PR is not running
mediasoup-worker-prebuild
, I think it's not gonna work. I assume that given the documentation of softprops/action-gh-release.Some info:
Bonus tracks: