versatica / mediasoup

Cutting Edge WebRTC Video Conferencing
https://mediasoup.org
ISC License
6.18k stars 1.12k forks source link

Try to make mediasoup-worker-prebuild CI task only run in releases #1280

Closed ibc closed 9 months ago

ibc commented 9 months ago

Fixes #1243

While it's true that this PR is not running mediasoup-worker-prebuild, I think it's not gonna work. I assume that given the documentation of softprops/action-gh-release.

Some info:

Bonus tracks:

ibc commented 9 months ago

You need to change the workflow to be triggered by release, not tag. And probably exclude rust-*

So you mean that my first commit was way better?

https://github.com/versatica/mediasoup/commit/61a645895c3f2b845f4f8a411a9987811ca58d0a

nazar-pc commented 9 months ago

So you mean that my first commit was way better?

I do think it should have been sufficient, also branches: [v3] was not necessary there.

BTW you can test how it performs by forking into personal repo and trying some tags/releases, from my experience that is sometimes the only way to find out how it works in practice.

ibc commented 9 months ago

@nazar-pc it looks that branches and tags are indeed acumulative, so I'll remove branches completely:

CleanShot-2023-12-29-at-10 22 43@2x

And yes, I¡ll do this in a fork.

ibc commented 9 months ago

I'm closing this PR and trying things in a personal mediasoup fork. Cosmetic changes done here are now in a separate PR https://github.com/versatica/mediasoup/pull/1281.

ibc commented 9 months ago

@nazar-pc let's follow the discussion and experiments in the issue report: https://github.com/versatica/mediasoup/issues/1243#issuecomment-1871895475