Closed ibc closed 10 months ago
So about changes in .eslintrc.js
:
worker/scripts/clang-format.mjs
.typescript-eslint
rules.Jest
stuff.plugin:prettier/recommended
in last position of the extends
array in eslintrc.js
as per documentation.'prettier/prettier': 2
in rules
to make ESlint fail if some file doesn't adhere to Prettier syntax.eslint-config-prettier
package and call it in npm run lint:node
task to ensure that we are not declaring any ESLint rule that is later gonna be overridden by plugin:prettier/recommended
rules:
// Ensure there are no rules that are unnecessary or conflict with Prettier
// rules.
executeCmd('eslint-config-prettier .eslintrc.js');
Details
Prettier
(proper paths filtered).npm run format:node
(plusnpm run format
which now formats Node and Worker).Why?
Bonus Tracks
.eslintrc.js
file. For example, it was not lintingnpm-scripts.mjs
properly.--detectOpenHandles
(no issues so far).