search

versatica / mediasoup

Cutting Edge WebRTC Video Conferencing
https://mediasoup.org
ISC License
6.18k stars 1.12k forks source link

C++: tidy up #1304

Closed jmillan closed 8 months ago

ibc commented 8 months ago

CI failing

jmillan commented 8 months ago

Can you comment a bit about how to use this? In which environment does it work? Only in Linux/Docker? Requirements? Do we have to install deps at global level or something? If so, which versions?

These are just code changes. The lint command is not YET uploaded, and even code changes have not finished. I'm doing those in different PRs. I'm going step by step. This is not as automated as it seems yet.

ibc commented 8 months ago

These are just code changes. The lint command is not YET be uploaded, and even code changes have not finished. I'm doing those in different PRs. I'm going step by step. This is not as automated as it seems yet.

Ok, so what is the command to make these errors show up? invoke tify?

jmillan commented 8 months ago

Ok, so what is the command to make these errors show up? invoke tify?

Yes, yes, how we call tidy will not change.

jmillan commented 8 months ago

@ibc, CI passing and ready to merge. Let me know if you have any concern so I'll continue with the next PR.

ibc commented 8 months ago

Approved.