Improvements ro Prettier and ESLint

versatica / mediasoup

Cutting Edge WebRTC Video Conferencing

https://mediasoup.org

ISC License

6.27k stars 1.13k forks source link

Improvements ro Prettier and ESLint #1305

Closed ibc closed 10 months ago

ibc commented 10 months ago

Details

In npm-scripts in lint:node and format:node tasks do NOT specify which paths to lint/format but instead rely on .eslintignore and .prettierignore, which MUST contain same paths.
Check prettier . --check in lintNode() in npm-scripts to ensure all files adhere to Prettier rules.

Bonus Tracks

Modernize CONTRIBUTING.md file and move it to root folder (so hopefully it will be listed in GH project in a tab with the README and LICENSE files).

ibc commented 10 months ago

Relevant commit to review is the first one: https://github.com/versatica/mediasoup/pull/1305/commits/80cc9a6c8195a63f6a36b05a68441256d975efe6

The second one is about automatic fomating changes done in files: https://github.com/versatica/mediasoup/pull/1305/commits/eae5dd4dc932aafa92d766ff5555b97b4713dcb1

ibc commented 10 months ago

Ok, the CONTRIBUTING.md file is not automatically added into a tab close to README and LICENSE, but that's a GH thing. CODE_OF_CONDUCT is but we don't have that.

CleanShot-2024-01-08-at-14 41 31@2x

ibc commented 10 months ago

Interesting: test failing due to aborted request. Wondering how it didn't happen before.

https://github.com/versatica/mediasoup/actions/runs/7448459449/job/20262892577#step:7:1

jmillan commented 10 months ago

Interesting: test failing due to aborted request. Wondering how it didn't happen before.

Seems the same the error we caught on Friday, the unhandled promise rejection.

ibc commented 10 months ago

I'm gonna merge this and fix the test issue separately.