search

versatica / mediasoup

Cutting Edge WebRTC Video Conferencing
https://mediasoup.org
ISC License
6.27k stars 1.13k forks source link

Add interface for RTC::Shared, Channel::ChannelNotifier and ChannelMessageRegistrator #1399

Closed o-u-p closed 6 months ago

o-u-p commented 6 months ago

Feature Request

this will make code more readable and flexible.

ibc commented 6 months ago

I don't know what this is about. Please specify much more hopefully with real code snippets.

o-u-p commented 6 months ago

for example, we can make "void ChannelNotifier::Emit(const std::string& targetId, FBS::Notification::Event event)" to be an interface, and can define some custom implement to send flatbuffer. that will be more flexible.

ibc commented 6 months ago

Please, feel free to write a PR proposal. Honestly we are too busy and won't have time to investigate this.