versatica / mediasoup

Cutting Edge WebRTC Video Conferencing
https://mediasoup.org
ISC License
6.27k stars 1.13k forks source link

Add TypeScript interfaces for all exported classes #1463

Closed ibc closed 5 days ago

ibc commented 1 week ago

Details

piranna commented 5 days ago
  • This makes it easier for applications to create mediasoup mocks.

Definitelly yes, that will be useful, just only now I have a bit of work to update Mafalda... Have you though / do you mind if we move the interfaces to a types-only package that can be used by both projects as dependency?

And related to this, do you know of any other Mediasoup mock/API project?

ibc commented 5 days ago

Have you though / do you mind if we move the interfaces to a types-only package that can be used by both projects as dependency?

This will probably happen but definitely not yet. Will be done once we use and evaluate how easy and useful those interfaces are, and probably more changes/additions are needed (spoiler: they are).

piranna commented 5 days ago

Yeah, I know they are useful, I think I asked for that interfaces several years ego for selfish reasons 😈 Just curious if it was already in the roadmap and how much soonish, or if I can help on that. I need first to fix the compatibility with 3.14.15 (I have been taking self-care and focused on my day job during last months and got totally disconnected of Mediasoup since at least May...), but after that I would need to have the types package, just only to know if do it as a nightly package that extract and publish them the same I'm doing with the tests to check for compatibility and other components, or do it by hand and make Mediasoup as dependent of it.

TL;DR: if you need help on moving out the interfaces, you can count on me.

ibc commented 5 days ago

We will reach that moment in which it will make sense to talk about a separate types package.