versatica / mediasoup

Cutting Edge WebRTC Video Conferencing
https://mediasoup.org
ISC License
6.15k stars 1.12k forks source link

preferTcp not honored #193

Closed artushin closed 6 years ago

artushin commented 6 years ago

If a room is created in mediasoup-client with transportOptions: {preferTcp: true}, the resulting remote candidate connection is shown in chrome://webrtc-internals/ as UDP. However, setting transportOptions: {udp: false} with the same SFU results in a working TCP connection.

ibc commented 6 years ago

Thanks a lot. The documentation was ok, but the default values were wrong:

https://github.com/versatica/mediasoup/commit/70d537f7eb060bfeb43d0c56920fd54a4aefdfb1

Fixed in 2.0.14 and published.

artushin commented 6 years ago

Same for https://github.com/versatica/mediasoup/blob/dc69b20c058a3be5139ce8718f5276ef04439c1d/worker/include/RTC/Transport.hpp#L62 options?

ibc commented 6 years ago

No, that's ok. The documentation, indeed, was wrong. Fixed now: https://mediasoup.org/documentation/mediasoup/api/#WebRtcTransport-MirroringOptions

Thanks.

artushin commented 6 years ago

Thanks!

On Mon, Feb 26, 2018 at 3:20 PM Iñaki Baz Castillo notifications@github.com wrote:

No, that's ok. The documentation, indeed, was wrong. Fixed now: https://mediasoup.org/documentation/mediasoup/api/#WebRtcTransport-MirroringOptions

Thanks.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/versatica/mediasoup/issues/193#issuecomment-368654559, or mute the thread https://github.com/notifications/unsubscribe-auth/ABgVBvBfsqeYlN63NS_U4RQbNxk6Hg2Eks5tYyA1gaJpZM4STzee .