search

versatica / mediasoup

Cutting Edge WebRTC Video Conferencing
https://mediasoup.org
ISC License
6.26k stars 1.13k forks source link

CodeQL: ignore some folders #966

Open ibc opened 1 year ago

ibc commented 1 year ago

Must tell .github/workflows/codeql.yml to ignore these folders:

art
doc
rust/benches
rust/examples
rust/examples-frontend
worker/deps
worker/subprojects
worker/scripts
worker/fuzzer
worker/out

There is a paths-ignore field in CodeQL that is just valid for interpreted languages (Python, JS, TS), however it doesn't work for compiled languages in which complex stuff must be done.

I found this but I don't understand it plus it seems to be outdated for CodeQL v1 CI actions.

UPDATE: As discussed here https://github.com/orgs/community/discussions/42654, .gitattributes is no longer valid to tell Code Search which folders to include/exclude, so:

This is not currently possible. If you're in the new Code Search beta you can exclude paths from your search by using a regex like this: NOT path:/worker\/deps/

For now I'll remove .gitattributes from mediasoup repo since it has zero value now.

ibc commented 1 year ago

As discussed here https://github.com/orgs/community/discussions/42654, .gitattributes is no longer valid to tell Code Search which folders to include/exclude, so:

This is not currently possible. If you're in the new Code Search beta you can exclude paths from your search by using a regex like this: NOT path:/worker\/deps/

For now I'll remove .gitattributes from mediasoup repo since it has zero value now.