search

verser-git / probe_screen_v2

40 stars 33 forks source link

LinuxCNC 2.8 support #3

Open benzkiller opened 4 years ago

benzkiller commented 4 years ago

It seems that newest LinuxCNC 2.8 changed axis names. NGC’s looking for example for axis2 and LinuxCNC newly named it AxisZ

GuiHue commented 4 years ago

I have created a fork where the offending elements were changed: https://github.com/GuiHue/probe_screen_v2

GuiHue commented 4 years ago

Fork has been updated: jogging is fixed now.

kiall commented 3 years ago

I've also added 2.8 support in a PR - https://github.com/verser-git/probe_screen_v2/pull/13 - more was needed since @GuiHue's original PR back in Sept 2019!

freisei commented 3 years ago

i looks like verser-git has activity since November 2018. I have done some modifications, improvements and debugging. Maybe i (and we all) should pull a merge-request on GuiHue´s Fork. And it could be a good idea to rename GuiHue´s Fork to probe_screen_v3.

I wanted to ask GuiHue by private message, but i couldn´t find any contact on his profile. Issues there are disabled? So i try this way :)

Greets from bavaria, Freisei

kiall commented 3 years ago

Yea, I have to to admit... I wasn't expecting a merge given the repo has been idle for so long!

Assuming @verser-git doesn't reply, how about we create a new GitHub org - fork there, and give anyone who's interested rights to the new org+repo. That feels more likely to last than any individual's fork.

(I'll volunteer to 1) set that up, 2) give everyone who is interested full / equal admin rights but only assuming no reply from verser within a few days)

freisei commented 3 years ago

I am in the team. When @verser-git isn´t responding until friday i think you can create a probe_screen_v3 repo. In the meantime i have to learn how to do commits on github. Let´s see what GuiHue is doing - maybe he can give good some more input too.

freisei commented 3 years ago

@kiall i think i does not make sense to wait anymore for versers response. Did you create a probe_screen_v3 repo? I´ve some useful improvements, so you can choose now between persistent-measured and every-time-measured tools. Plus: the preview is now in correct z-position and the g54 z-offset is used correctly.

kiall commented 3 years ago

@kiall i think i does not make sense to wait anymore for versers response. Did you create a probe_screen_v3 repo?

https://github.com/linuxcnc-probe-screen/probe-screen - I've added you, and anyone else who wants to contribute can just ask.

I´ve some useful improvements, so you can choose now between persistent-measured and every-time-measured tools. Plus: the preview is now in correct z-position and the g54 z-offset is used correctly.

:+1: