Support VS 2013

[ibuchanan]

As a developer, I want to use the VS Client inside VS 2013 so that I can run the latest and greatest Microsoft software.

VS 2013 is now RTM: http://mobile.eweek.com/developer/microsoft-delivers-final-version-of-visual-studio-2013.html

Acceptance Criteria Outline:

• [ ] We can spin up the test environment with VS2013 (for supported editions)
• [x] Installs into VS2013
• [x] Does it still do the things we expect it to do? (based on Issue #64 ).
• [x] System requirements in user docs indicate testing of VS2013.

See features for detailed spec.

[ibuchanan]

Seems like the fix is to change the version range in the vsixmanifest: [11.0,13.0)

[JogoShugh]

Next Steps

Valentin:

• Create a vs2013_support branch
• Incorporate modifications to support installation in 2012 and 2013
• Include upgrading the project itself to 2013 structure (Migrated)
• Checkin changes to this branch

Josh:

• Create chef role (Cloudformation repo) that can install Visual Studio 2013 Professional, Premium

[veplechuc]

On Vs 2013(Ultimate) I have some issues while open the project:

when open for the first time it migrates from VS2012 to VS2013 (see UpgradeLog.htm on the project directory) on this report you will see all the information about of how was the migration process

this warning windows (vs2013WarningMessage)

_One-way upgrade Visual Studio will automatically make functional changes to the following projects in order to open them. You will not be able to open these projects in the version of Visual Studio in which they were originally created.

• VersionOne.VisualStudio.VSPackage, "C:\VersionOne.VisualStudio.VSPackage\VersionOne.VisualStudio.VSPackage.csproj" Non-functional changes required Visual Studio will automatically make non-functional changes to the following projects in order to enable them to open in Visual Studio 2013, Visual Studio 2012, and Visual Studio 2010 SP1. Project behavior will not be impacted.
• VersionOne.VisualStudio.VSPackage, "C:\VersionOne.VisualStudio.VSPackage.sln" No changes required These projects can be opened in Visual Studio 2013, Visual Studio 2012, and Visual Studio 2010 SP1 without changing them.
• VersionOne.VisualStudio.DataLayer, "C:\VersionOne.VisualStudio.DataLayer\VersionOne.VisualStudio.DataLayer.csproj"
• VersionOne.VisualStudio.Tests, "C:\VersionOne.VisualStudio.Tests\VersionOne.VisualStudio.Tests.csproj"
• .nuget, ".nuget"_

NOTE: If you have already installed the VS SDK you won´t get these issues mentioned below

when I try to open the VSPackage it shows me that it is incompatible (see vs2013-projectIncompatible.jpg)

try to build the project Error 12 The imported project "C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v12.0\VSSDK\Microsoft.VsSDK.targets" was not found. Confirm that the path in the declaration is correct, and that the file exists on disk.
C:\VersionOne.VisualStudio.VSPackage\VersionOne.VisualStudio.VSPackage.csproj
VersionOne.VisualStudio.Tests

Solution:

I downloaded from Ms [http://www.microsoft.com/visualstudio/eng/downloads] or from chocolatey Installed it modify the maifest, adding this line

InstallationTarget Version="[12.0,13.0)" Id="Microsoft.VisualStudio.Ultimate"

and it allows me to install the plug in on the vs 2013 (see img vs2013-aftemodifymanifest.jpg)

NOTE: If you are using some other version than Ultimate, you should add a new line with the corresponding info. InstallationTarget Version="[12.0,13.0)" Id="Microsoft.VisualStudio.Ultimate" InstallationTarget Version="[12.0,13.0)" Id="Microsoft.VisualStudio.Pro" InstallationTarget Version="[12.0,13.0)" Id="Microsoft.VisualStudio.Premium"

when trying to install trows me this error (vs2013-errorinstallplugin.jpg) see also this reference [http://stackoverflow.com/questions/18095344/how-to-solve-microsoft-visualstudio-extensionmanager-missingreferencesexception]

remove this line from manifest:

Dependency d:Source="Manual" Id="Microsoft.VisualStudio.MPF" DisplayName="Visual Studio MPF" Version="10.0" d:InstallSource="Manual"

rebuild the solution install the plug in restart the VS added the required information to the plug In

[JogoShugh]

Decision

• We will, for the time being, continue to build in 2012 because we verified that we can build in 2012 yet still include 2013 as an installation target -- that will enable USERS to have 2013 support.
• For DEVELOPERS who want to build with 2013, we will include instructions in README that describe how to build in 2013 if someone wants to, since it amounts to just two things: 1) Installing the VS 2013 SDK. (If you have Chocolatey: cinst VS2013SDK), and 2) Changing the MinimumVisualStudioVersion from 11 to 12 in the VSPackage csproj.

Options

NOTE: The discussion below may be helpful in future decisions, but for now, we've decided upon the solution above.

@veplechuc and I are discussing how to properly handle / support developers targeting lower editions of Studio (like 2012 now that 2013 is the current)

Here are some options we see:

A) Migrate master solution to 2013 , allow community to "fend for themselves" on lower editions

Pros:

• Keeps a single branch to "keep up with" and keeps up "at the latest".
• Our binaries built from 2013 can still be installed and run in 2012

Cons:

• If a dev tries to open the solution in 2012 (or lower), it gives an ugly warning, and then cannot open the VSPackage project -- thus making it more difficult for them to contribute improvements or make changes that they need in their own shops.
• Increase StackOverflow chatter about lack of developer support for downlevel versions.

B) Migrate master solution to 2013, retain a "vs2012solution" branch with 2012 solution

Pros:

• The code itself, so far, appears to work fine in both 2012 and 2013!
• Gives a simple way for devs who don't even have 2013 (and whose organizations might not buy it for 2 more years!) to still build the code and make any local changes they need to against it.
• If in 2014, there are significant changes to the architecture and libraries of 2014, the 2012 and 2013 editions can continue to live as "Open source, community supported" projects in their own right.
• Plus, if WE CHANGE the approach to be a better Mature band product, the existing clients can still live as "Open source, community supported" projects even as the new approach is "iterated and evolved" to a product that "customers love". * See Cagan

Cons:

• Might complicate the testing story a little bit, but mitigating factors are:
  • 1) Valentin and I have already confirmed that we can build in 2013, and still produce a VSIX that installs into 2012 AND 2013
  • 2) Because of 1) we don't have to compromise our message of "Support for 2012 and 2013" because the binaries that WE produce will work against both.

[JogoShugh]

It appears that the only thing that needs to be changed for building in 2012 instead of 2013 is this single line in VersionOne.VisualStudio.VSPackage:

From 12.0 (2013)

<MinimumVisualStudioVersion>12.0</MinimumVisualStudioVersion>

To 11.0 (2012)

<MinimumVisualStudioVersion>11.0</MinimumVisualStudioVersion>

Setting the value to 11.0 results in the project opening successfully in 2012. It can then be compiled fine, and because the manifest still lists 2013 as a target, it will also install and work in 2013.

However, if you try to open the project in 2013, you'll get a one way upgrade warning that @veplechuc mentioned above. If you let it upgrade, all it does is change that one line to 12.0.

[ibuchanan]

We also need this for the V1TFS integration. In order to keep from switching projects, let's wrap up whatever we can on this in the next week. If there's unfinished work, we'll create new issues in V1TFS and track them there.

[ibuchanan]

We completed the main thread of work for VS 2013 with last iteration but kept this issue open to make sure we did the automation work to spin up new environments. We still need this for TFS Integration so I've created the above issue for that. Let's move the discussion and tracking of that remaining work over to that project.