Right click over some nodes makes the plugin crash.

[lremedi]

Right click over some nodes of the tree, makes crash the plugin and VS. This issue was present before upgrading version of TreeViewNode.

[davidhaimovich]

When the popup is opened, the application checks if the story/defect owners belong to the logged in user (in the isMine() method). If not, it disables the popup item "-Signup".

    public bool IsMine() {
        var owners = (PropertyValues)GetProperty(OwnersProperty);
        return owners.ContainsOid(DataLayer.MemberOid);
    }

When tries to get the owners of the story/defect, it invokes this code:

        public virtual object GetProperty(string propertyName) {

        if (propertyName == EffortProperty) {
            return EntityContainer.GetEffort(this);
        }

        var attribute = Asset.Attributes[TypePrefix + '.' + propertyName];
        var allValues = GetPropertyValues(propertyName);

        if (attribute.Definition.IsMultiValue) {
            var currentValues = attribute.Values;
            return allValues == null ? currentValues : allValues.Subset(attribute.Values);
        }

        var value = attribute.Value;

        if (value is Oid) {
            return allValues == null ? value : allValues.Find((Oid)value);
        }

        return value;
        }

Because the owners of the story/defect (attribute) is not in the allValues list (all owners), an KeyNotFoundException is thrown.

The question is : why the owner is not present in allValues list? If is not present should we catch the exception, and return false in the isMine() method?

[JogoShugh]

Under debug we determined so far:

• For workitems that have an owner who is DEACTIVATED, the workitem's owner is BLANK in the UI
• When clicking on one of those ownerless items, the plugin crashes because there is missing information from a list of Owners values that appears to have been loaded in the V1Tracker constructor
• @morrica01 helped us figure out where to reactive the user. Doing this caused the exception to stop.
• However, this is still wrong behavior that needs to be fixed. That is, the owner SHOULD BE returned -- we think.

[JogoShugh]

@morrica01 says:

• If user is inactivated, but assigned to a workitem/asset as an owner, then you should:
  • See their name, but with a strike-through, in the Task List, (just like it appears in the VersionOne web app in an Detail View)
  • Not be able to select the user for assigning to a new Workitem/Task

Question: Should user be able to edit an existing item and resave it when the owner is inactive?

Carlena Notes:

• Member can be assigned to multiple different projects, and at different levels of the project Tree
  • If there is a project tree with levels of 1 -> 1.1 -> 1.1.1, and the user is a member at level 1.1, then they can see sub-projects (Scopes in VersionOne terms) and Workitems in levels 1.1 and 1.1.1, but not in 1.

[ibuchanan]

There seem to be multiple scenarios packed into all of this:

Given a Member named "Ian Inactivated",
And a Story named "Story with Inactivated Member" with "Ian Inactivated" as the Owner,
And "Ian Inactivated" has been Inactivated,

When I look at "Story with Inactivated Member"
Then ...

When I open the Owner drop-down for "Story with Inactivated Member"
Then ...

When I try to save a change to "Story with Inactivated Member"
Then ...

When I try to sign up for "Story with Inactivated Member"
Then ...

[ibuchanan]

For release notes...

Fixed: Inactivated owner now shown with strike-through. Context menu now available for items with inactivated members.

[davidhaimovich]

Inactive user will be shown in the owners combo selector only when is already assigned to the asset. If not, no inactive users should be shown there.

notes:

• Is possible to have a strike-through value inside the combo selector?

[davidhaimovich]

We could show the inactive user in the node and, the active users in the combo. We could set as strikeout the inactive user in the node.

¿What happens if in the node we have one active and one inactive user? Now, it is setting both as strikeout:

Image as example:

[ibuchanan]

Q: What happens when we have one active and one inactive Member? A: In the web application, only the inactivate Member has strike-through. The active user is shown normally.

[davidhaimovich]

One solution is to add "-" after and before the user name when is inactive: e.g.

[JogoShugh]

Needs more amigos review :) Questions on user-value of the "-" approach. Explore more options.

[davidhaimovich]

Notes:

• In the owner columns the name of the user has been replaced with the "Nickname".
• After Refresh the plugin, a change in the name (or nickname) from web application was not being refreshed. Fixed too.

[ibuchanan]

Examples of Inactive Members in Owners List

ianb and joe are inactive Members. josh is an active Member.

One Inactive Member

(Inactive: ianb), josh

Multiple Inactive Members

(Inactive: ianb), josh, (Inactive: joe)

Showing Inactive Members in Dropdown

(Inactive: ianb) josh (Inactive: joe)

[davidhaimovich]

[davidhaimovich]

Test Steps:

• Look for an asset assigned to an inactive member.
• Check that when right clicking on it, the plugin shows the popup and do not crash.
• Check that the inactive member is marked as inactive. (Inactive: inactiveUser)
• Check that when right clicking on it, the plugin shows in the popup the inactive user.
• Check that when right clicking on an "active" member, no inactive ones are displayed in the popup.
• Check that the member displays the short name and not the name.
• If the short name or the inactive status is edited from web after the plugin is loaded, after refreshing, the members should be updated.