please pull my asof() related patches

versionone / VersionOne.SDK.Python

A library for custom Python development against the VersionOne Platform's REST-based API.

BSD 3-Clause "New" or "Revised" License

23 stars 32 forks source link

please pull my asof() related patches #5

Closed bazsi closed 11 years ago

bazsi commented 11 years ago

The first one fixes asof() so that the AsOf attribute is added to the returned objects.

The second will allow passing None to the asof() function, which is equivalent of not using asof at all. This is also possible to add when a list of asof() values are passed, e.g.

v1.PrimaryWorkitems.filter(...).asof("2011-01-01", "2011-02-01", None)

returns 3 sets of data, two for the specific dates, and the third for the actual state.

Please Apply! Thanks

bazsi commented 11 years ago

any news on merging this? some feedback that prevents that? thanks

I have another patch waiting in my repository.

jkoberg commented 11 years ago

Hi there, we've just been busy with a Hack Week so I've been ignoring emails.

Thanks for the PR, I'll review and pull it today if all looks good!

bazsi commented 11 years ago

Thanks for merging this, going to submit the next round too.