search

versolearning / meteor-intercom

Reactive intercom integration for Meteor
47 stars 15 forks source link

Implement intercom booting for logged out users #13

Closed julie-is-late closed 9 years ago

julie-is-late commented 9 years ago

With the intercom acquire package, you can use the intercom messenger for users who are not logged into your app, and therefore do not have a user id.
This code expands the API to allow for this, adding settings to enable it, and keeping with the original conventions of laying out the functions.

tmeasday commented 9 years ago

Looks great, thanks @jshap70!

I'll have to take your word for it that this works as we don't use this feature. Will you be able to take responsibility for maintaining it? (Again will be hard for us to do..)

julie-is-late commented 9 years ago

Thanks! And yes, I will be able to take up maintaining it.

tmeasday commented 9 years ago

Ok, I've added you as a contributor. Let me know your MD username and I'll give you permission to publish a new version of the package.

julie-is-late commented 9 years ago

okay, cool. My md username is jshap70.

tmeasday commented 9 years ago

Hi @jshap70 - I've added you as a maintainer. Feel free to merge these changes and push a new version.

julie-is-late commented 9 years ago

Okay, correct me if I'm missing something but I don't believe I was correctly added as a contributor, as I do not have the write access to be able to merge this PR.

tmeasday commented 9 years ago

Apologies, I sent the invitation to the wrong person (!)