search

versolearning / meteor-intercom

Reactive intercom integration for Meteor
47 stars 15 forks source link

Installing percolate intercom without id in Meteor.settings breaks the app #16

Closed sathishc closed 9 years ago

sathishc commented 9 years ago

screen shot 2015-09-19 at 11 05 38 pm

Would it be good if exception thrown and app continues to run without Intercom integration?

gsuess commented 9 years ago

+1 Not every deployment should need to have an intercom instance configured to run the app once this package is installed.

The settings should be optional IMO.

zol commented 9 years ago

I will accept a PR for otherwise I'll tackle it in a future round of development.

zol commented 9 years ago

I've added a warning. Looking at the code more closely, it's impractical to do anything else as the intercom snippet itself uses the id.