versotile-org / verso

A web browser that plays old world blues to build new world hope
Apache License 2.0
4.68k stars 156 forks source link

Release versoview to github releases #203

Closed Legend-Master closed 4 weeks ago

wusyong commented 1 month ago

Is there any artifact or release uploaded successfully from your fork?

Legend-Master commented 1 month ago

Still testing, it takes way too long to build

Legend-Master commented 1 month ago

Trying on https://github.com/Legend-Master/verso/actions/runs/11359419399

Legend-Master commented 1 month ago

Good run https://github.com/Legend-Master/verso/actions/runs/11361145367, I removed and re-released to https://github.com/Legend-Master/verso/releases/tag/versoview-v0.0.1

wusyong commented 1 month ago

I think we can take this chance to swap the crate names to test if all CI could pass. Could you rename verso to versoview for now? And vice versa.

Legend-Master commented 1 month ago

I can try it, I think we just need to change the package names in the CI and it should work

Running one at https://github.com/Legend-Master/verso/actions/runs/11397055642

Legend-Master commented 1 month ago

I think it worked https://github.com/Legend-Master/verso/commit/6cb27dd7f72e12dd9e11a847d2c012e3fa7c9f16

wusyong commented 4 weeks ago

I think it worked Legend-Master@6cb27dd

Could you change the crate names in this PR?

Legend-Master commented 4 weeks ago

I'm not quite sure what you want, I can swap the crate names but isn't it just for testing? Swapping the names for real doesn't make much sense to me

wusyong commented 4 weeks ago

As discussed in zulip, the second crate should be verso actually. The name of shared binary hasn't decided yet, but I think we could swap it for now. So we can test all CIs are working when the names are different.

Legend-Master commented 4 weeks ago

Kinda get it now, so the 'core' (currently verso) will be named versoview, and the current versoview will be changed to verso which will produce the binary? What about the current versoview (webview controller)? I would probably want to discuss about this a bit more before doing it

I'll get some food and be back in an hour

wusyong commented 4 weeks ago

The core will still produce the binary. The webview controller you mean will be named as verso. It will be both a browser and a library to provide webview api.

Legend-Master commented 4 weeks ago

Cherry picked that commit in