search

versotile-org / verso

A web browser that plays old world blues to build new world hope
Apache License 2.0
4.68k stars 156 forks source link

Allow disable pinch zoom from cli #239

Open Legend-Master opened 5 days ago

Legend-Master commented 5 days ago

Enable touch support and allow disable pinch zoom from command line flag

wusyong commented 2 days ago

What's the motivation to disable pinch zoom as a configuration?

Legend-Master commented 2 days ago

This allows you to use your own pinch zoom handlings, for example https://figma.com and https://squoosh.app, I don't think we have preventDefault on touch events implemented currently, so this is a work around for now, also some people just want to make their web app (webview app) feel like a native app with all those web features disabled (personally I'm not a fan of it but there're people want that)

wusyong commented 2 days ago

It should implement preventDefault on touch events to Servo directly. I think we could explore other CLI options that could be more crucial.

Legend-Master commented 2 days ago

Sure we can, but I still want to argue that attaching non passive touch event listeners hurt performance