versotile-org / verso

A web browser that plays old world blues to build new world hope
Apache License 2.0
61 stars 9 forks source link

keyboard: support all key conversions #69

Open pewsheen opened 3 days ago

pewsheen commented 3 days ago

Follow up from #67

Super, Capslock are not recognized by the webview.

wusyong commented 2 days ago

I think this is simply because we haven't supported all key conversions. We can use this issue as feature request to add more key supports.

wusyong commented 2 days ago

There are three methods that haven't supported all conversions yet:

https://github.com/versotile-org/verso/blob/a64b679741562531a28372c1ae0fbe2d97487be8/src/keyboard.rs#L20

https://github.com/versotile-org/verso/blob/a64b679741562531a28372c1ae0fbe2d97487be8/src/keyboard.rs#L120

https://github.com/versotile-org/verso/blob/a64b679741562531a28372c1ae0fbe2d97487be8/src/keyboard.rs#L150

Feel free to open PR to add some conversions. We can add this step by step. Perhaps we can also open more issues to list out missing keys.