ClojureVerticleFactory should serialize verticle start()

vert-x / mod-lang-clojure

Vert.x 2.x is deprecated - use instead

http://vertx.io

Other

74 stars 15 forks source link

ClojureVerticleFactory should serialize verticle start() #134

Closed tobias closed 8 years ago

tobias commented 9 years ago

If clojure.jar is on the classpath, verticles don't get isolated runtimes, which isn't really a problem in itself, but does cause issues with namespaces being accessed before they are completely loaded. Serializing start() should prevent that.

tobias commented 9 years ago

I now realize this is also an issue even when you don't have a clojure.jar on the classpath, since multiple instances of the same verticle will share the same runtime, and may collide loading namespaces there as well.

prio commented 9 years ago

Hi Toby. Have been testing this since last Friday and my application is behaving much better, no longer seeing the errors I was previously seeing when restarting.

tobias commented 9 years ago

@prio - thanks for the feedback! This has been released in v1.0.5 if you want to move past the SNAPSHOT.