search

vert-x / mod-lang-groovy

Vert.x 2.x is deprecated - use instead
https://github.com/vert-x3/vertx-lang-groovy
Other
16 stars 15 forks source link

jar.enabled should be true #3

Closed samart closed 11 years ago

samart commented 11 years ago

this is a bad merge?

https://github.com/vert-x/mod-lang-groovy/commit/0d8bf8b45c3f4fee792acb23aee1f955ebf567a4

it rolled back Tim's change.

https://github.com/vert-x/mod-lang-groovy/commit/3441606ccbcb4dd679189b31bc2b02947b50d1ff

I need the lang-groovy jar for a maven compile time dependency.

pidster commented 11 years ago

Adding the jar broke the snapshot pom for me, vert.x tried to download the .jar rather than the module .zip.

samart commented 11 years ago

but you need it for compile no? if i am writing a groovy verticle, i need to compile with lang-groovy.jar in the class path...how can you compile witthout it?

i just assumed vertx would pull down the .zip module and ignore the jar?

things work ok for me with this setting.

vertx-platform/../resources/langs.propertiies

the file above controls the module download with this line, i think:

groovy=maven:io.vertx:lang-groovy:1.0.0-SNAPSHOT:org.vertx.groovy.platform.impl.GroovyVerticleFactory

[INFO] --- vertx-maven-plugin:2.0.0.0-SNAPSHOT:run (default-cli) @ base --- [INFO] Vert.X home: /Users/samart/development/projects/opbot/vertx-2.0.0-SNAPSHOT [INFO] Vert.X modules: /Users/samart/development/projects/opbot/opbot-server/target [INFO] Launching verticle [groovy:org.vertbase.VerticleBase] Mar 06, 2013 7:00:04 PM org.vertx.java.core.logging.impl.JULLogDelegate info INFO: Downloading io.vertx:lang-groovy:1.0.0-SNAPSHOT. Please wait... Mar 06, 2013 7:00:06 PM org.vertx.java.core.logging.impl.JULLogDelegate info INFO: Module maven:io.vertx:lang-groovy:1.0.0-SNAPSHOT successfully installed 19:00:07.231 [vert.x-core-thread-2] INFO verticalBase - Verticle started

pidster commented 11 years ago

Are you using Maven? [edit] Yes, obviously you are.

I will need to look into this. Maybe the vert.x maven module resolver needs to be more specific about the artefact type that it's searching for and we can restore the jar.

When the jar was uploaded, the classpath resolved but the internal lookup & download did not work. Gradle resolves the zip as if it's a jar - which is why I reverted it.

purplefox commented 11 years ago

Yes, the Groovy lang build should have jar_enabled = true for the reasons mentioned above.

pidster commented 11 years ago

I am looking at this now.

purplefox commented 11 years ago

Thinks also work fine for me with this setting too, and I find it hard to see how Vert.x would be downloading a jar instead since it always specifies .zip on the uri: https://github.com/vert-x/vert.x/blob/master/vertx-platform/src/main/java/org/vertx/java/platform/impl/resolver/MavenResolution.java#L86

purplefox commented 11 years ago

Perhaps a bug in Gradle itself? (wild guess)

pidster commented 11 years ago

Well, reverting the jar fixed the groovy app I'm working on... Maybe it was related to the maven local pom change that went in recently.