search

vert-x / mod-lang-groovy

Vert.x 2.x is deprecated - use instead
https://github.com/vert-x3/vertx-lang-groovy
Other
16 stars 15 forks source link

#12 & #13 - Enable optional usage of Groovy CompilationConfiguration #45

Closed danthegoodman closed 10 years ago

danthegoodman commented 10 years ago

This is in reference to Issue #12, and an extension upon Pull Request #13.

The pull request hadn't been updated in a while and it needed some cleanup before it could be accepted, so I took it upon myself to clean up the pull request. Here are my modifications:

  1. Remove mod/* files accidentally commited.
  2. Refafactor configuration creation into it's own method
  3. Replace try{} finally{} with withInputStream
  4. Configuration comes from java property instead of environment variable, since that's more in line with other vertx configuration.
  5. If configuration property is not set, configuration may also come from a groovy script.
  6. Added javadocs to class.
  7. Updated tests

Eclipse CLA signed by danny@kirchmeier.us

LostInBrittany commented 10 years ago

Going to review it, and if test are ok, I'll merge the pull request tonight

LostInBrittany commented 10 years ago

Merge done, thanks!!!!