search

vert-x / mod-lang-groovy

Vert.x 2.x is deprecated - use instead
https://github.com/vert-x3/vertx-lang-groovy
Other
16 stars 15 forks source link

Append and setBytes with offset and len on Buffer #56

Closed danthegoodman closed 10 years ago

danthegoodman commented 10 years ago

Fixes #54

Signed-off-by: Danny Kirchmeier danny@kirchmeier.us

LostInBrittany commented 10 years ago

Could you please add some unit test? We try to have at least some unit testing for all new functionalities.

If it isn't possible, I'll merge and add an issue for the test (that I'll try to do as soon as possible).

danthegoodman commented 10 years ago

@LostInBrittany Tested.

I had some trouble with the tests, but eventually figured out the langs file had the wrong version in it. I merged in master since it had the correct version.

LostInBrittany commented 10 years ago

@danthegoodman thanks a lot for the test, and for the quickness in doing them, it's great!